Statement Of Equity - USD ($) $ in Thousands	Cumulative Preferred Shares [Member]	Common Shares [Member]	Paid-In Capital [Member]	Accumulated Deficit [Member]	Accumulated Other Comprehensive Loss [Member]	Total Public Storage Shareholders' Equity [Member]	Noncontrolling Interests [Member]	Total
Balances at Dec. 31, 2017	$ 4,025,000	$ 17,385	$ 5,648,399	$ (675,711)	$ (75,064)	$ 8,940,009	$ 24,360	$ 8,964,369
Issuance of common shares in connection with share-based compensation		21	7,922			7,943		7,943
Share-based compensation expense, net of cash paid in lieu of common shares			40,987			40,987		40,987
Contributions by noncontrolling interests							1,342	1,342
Net income				1,129,317		1,129,317		1,129,317
Net income allocated to noncontrolling interests				(4,491)		(4,491)	4,491	(4,491)
Distributions to:
Preferred shareholders (Note 8)				(162,238)		(162,238)		(162,238)
Noncontrolling interests							(5,262)	(5,262)
Common shareholders and restricted share unitholders				(1,047,161)		(1,047,161)		(1,047,161)
Other comprehensive (loss) income (Note 2)					(9,275)	(9,275)		(9,275)
Balances at Sep. 30, 2018	4,025,000	17,406	5,697,308	(760,284)	(84,339)	8,895,091	24,931	8,920,022
Balances at Jun. 30, 2018	4,025,000	17,394	5,673,078	(735,065)	(84,601)	8,895,806	24,986	8,920,792
Issuance of common shares in connection with share-based compensation		12	6,232			6,244		6,244
Share-based compensation expense, net of cash paid in lieu of common shares			17,998			17,998		17,998
Contributions by noncontrolling interests							590	590
Net income				379,589		379,589		379,589
Net income allocated to noncontrolling interests				(1,562)		(1,562)	1,562	(1,562)
Distributions to:
Preferred shareholders (Note 8)				(54,080)		(54,080)		(54,080)
Noncontrolling interests							(2,207)	(2,207)
Common shareholders and restricted share unitholders				(349,166)		(349,166)		(349,166)
Other comprehensive (loss) income (Note 2)					262	262		262
Balances at Sep. 30, 2018	4,025,000	17,406	5,697,308	(760,284)	(84,339)	8,895,091	24,931	8,920,022
Balances at Dec. 31, 2018	4,025,000	17,413	5,718,485	(577,360)	(64,060)	9,119,478	25,250	9,144,728
Issuance of preferred shares (Note 8)	601,250					584,071		584,071
Issuance of preferred shares (Note 8), adjustment to APIC			(17,179)
Redemption of preferred shares (Note 8)	(860,000)					(860,000)		(860,000)
Issuance of common shares in connection with share-based compensation		25	32,984			33,009		33,009
Share-based compensation expense, net of cash paid in lieu of common shares			8,805			8,805		8,805
Acquisition of noncontrolling interests			(23,913)			(23,913)	(11,087)	(35,000)
Contributions by noncontrolling interests							2,051	2,051
Net income				1,138,554		1,138,554		1,138,554
Net income allocated to noncontrolling interests				(4,035)		(4,035)	4,035	(4,035)
Distributions to:
Preferred shareholders (Note 8)				(158,565)		(158,565)		(158,565)
Noncontrolling interests							(5,420)	(5,420)
Common shareholders and restricted share unitholders				(1,048,816)		(1,048,816)		(1,048,816)
Other comprehensive (loss) income (Note 2)					(14,453)	(14,453)		(14,453)
Balances at Sep. 30, 2019	3,766,250	17,438	5,719,182	(650,222)	(78,513)	8,774,135	14,829	8,788,964
Balances at Jun. 30, 2019	3,737,500	17,429	5,729,945	(648,391)	(67,549)	8,768,934	25,576	8,794,510
Issuance of preferred shares (Note 8)	316,250					307,348		307,348
Issuance of preferred shares (Note 8), adjustment to APIC			(8,902)
Redemption of preferred shares (Note 8)	(287,500)					(287,500)		(287,500)
Issuance of common shares in connection with share-based compensation		9	15,610			15,619		15,619
Share-based compensation expense, net of cash paid in lieu of common shares			6,442			6,442		6,442
Acquisition of noncontrolling interests			(23,913)			(23,913)	(11,087)	(35,000)
Contributions by noncontrolling interests							749	749
Net income				399,420		399,420		399,420
Net income allocated to noncontrolling interests				(1,478)		(1,478)	1,478	(1,478)
Distributions to:
Preferred shareholders (Note 8)				(50,028)		(50,028)		(50,028)
Noncontrolling interests							(1,887)	(1,887)
Common shareholders and restricted share unitholders				(349,745)		(349,745)		(349,745)
Other comprehensive (loss) income (Note 2)					(10,964)	(10,964)		(10,964)
Balances at Sep. 30, 2019	$ 3,766,250	$ 17,438	$ 5,719,182	$ (650,222)	$ (78,513)	$ 8,774,135	$ 14,829	$ 8,788,964