Statements Of Income - USD ($) shares in Thousands, $ in Thousands	3 Months Ended		9 Months Ended
	Sep. 30, 2018	Sep. 30, 2017	Sep. 30, 2018	Sep. 30, 2017
Revenues:
Total revenues	$ 706,368	$ 686,361	$ 2,061,820	$ 1,996,220
Expenses:
Self-storage cost of operations	183,637	173,315	545,700	516,488
Ancillary cost of operations	11,907	17,304	33,648	39,611
Depreciation and amortization	124,516	113,320	362,272	334,426
General and administrative	27,429	22,311	90,278	62,331
Operating expenses	347,489	326,250	1,031,898	952,856
Operating income	358,879	360,111	1,029,922	1,043,364
Interest and other income	7,020	4,569	18,892	12,722
Interest expense	(8,094)	(2,389)	(24,589)	(4,553)
Equity in earnings of unconsolidated real estate entities	17,771	17,218	90,529	57,235
Foreign currency exchange gain (loss)	2,612	(13,446)	12,738	(44,452)
Casualty loss		(7,789)		(7,789)
Gain on sale of real estate	1,401		1,825	975
Net income	379,589	358,274	1,129,317	1,057,502
Allocation to noncontrolling interests	(1,562)	(1,600)	(4,491)	(4,684)
Net income allocable to Public Storage shareholders	378,027	356,674	1,124,826	1,052,818
Allocation of net income to:
Preferred shareholders- distributions	(54,080)	(61,055)	(162,238)	(182,457)
Preferred shareholders - redemptions (Note 8)		(14,692)		(29,330)
Restricted share units	(1,268)	(1,210)	(3,790)	(3,502)
Net income allocable to common shareholders	$ 322,679	$ 279,717	$ 958,798	$ 837,529
Net income per common share:
Basic	$ 1.85	$ 1.61	$ 5.51	$ 4.83
Diluted	$ 1.85	$ 1.61	$ 5.50	$ 4.81
Basic weighted average common shares outstanding	173,975	173,715	173,933	173,560
Diluted weighted average common shares outstanding	174,348	174,240	174,240	174,128
Self-Storage Facilities [Member]
Revenues:
Total revenues	$ 666,616	$ 646,238	$ 1,943,359	$ 1,878,215
Ancillary Operations [Member]
Revenues:
Total revenues	$ 39,752	$ 40,123	$ 118,461	$ 118,005