Statements Of Comprehensive Income (USD $) In Thousands, unless otherwise specified	12 Months Ended
	Dec. 31, 2011	Dec. 31, 2010	Dec. 31, 2009
Statements Of Comprehensive Income [Abstract]
Net income	$ 836,459	$ 696,114	$ 790,456
Other comprehensive (loss) income:
Aggregate foreign currency translation adjustments for the period	(14,528)	(43,035)	26,591
Adjust for foreign currency translation loss (gain) recognized during the period	7,287	42,264	(9,662)
Other comprehensive (loss) income for the period	(7,241)	(771)	16,929
Total comprehensive income	829,218	695,343	807,385
Comprehensive income allocated (to) from noncontrolling interests:
Based upon income of the subsidiaries	(12,617)	(23,676)	(27,835)
Based upon repurchases of preferred partnership units		(400)	72,000
Comprehensive income allocable to Public Storage Shareholders	$ 816,601	$ 671,267	$ 851,550