Segment Information (Summary Of Segment Information) (Details) (USD $) In Thousands	3 Months Ended				9 Months Ended
	Sep. 30, 2011		Sep. 30, 2010		Sep. 30, 2011		Sep. 30, 2010
Segment Reporting Information [Line Items]
Self-storage facilities	$ 416,104		$ 388,932		$ 1,196,352		$ 1,126,285
Ancillary operations	30,011		26,588		85,817		78,823
Interest and other income	6,875		6,775		25,218		22,023
Total revenues	452,990		422,295		1,307,387		1,227,131
Self-storage facilities	128,976		127,423		394,030		387,328
Ancillary operations	9,793		7,091		28,304		25,060
Depreciation and amortization	90,935		92,583		268,601		262,135
General and administrative	14,116		8,910		40,944		29,068
Interest expense	5,862		7,838		18,779		22,455
Total expenses	249,682		243,845		750,658		726,046
Income (loss) from continuing operations before equity in earnings of real estate entities, foreign currency exchange loss and gains on real estate sales and debt retirement, net and asset impairment charges	203,308		178,450		556,729		501,085
Equity in earnings of real estate entities	15,269		9,043		41,755		27,792
Foreign currency exchange loss	(28,253)	[1]	55,455	[1]	13,495	[1]	(28,592)	[1]
Gains on real estate sales and debt retirement, net	4,983				5,111		679
Asset impairment charges	(2,186)				(2,186)		(1,949)
Income (loss) from continuing operations	193,121		242,948		614,904		499,015
Discontinued operations	1,392		2,863		1,118		7,889
Public Storage Shareholders	194,513		245,811		616,022		506,904
Domestic Self-Storage [Member]
Segment Reporting Information [Line Items]
Self-storage facilities	416,104		388,932		1,196,352		1,126,285
Total revenues	416,104		388,932		1,196,352		1,126,285
Self-storage facilities	128,976		127,423		394,030		387,328
Depreciation and amortization	90,276		91,928		266,614		260,170
Total expenses	219,252		219,351		660,644		647,498
Income (loss) from continuing operations before equity in earnings of real estate entities, foreign currency exchange loss and gains on real estate sales and debt retirement, net and asset impairment charges	196,852		169,581		535,708		478,787
Equity in earnings of real estate entities	450		467		1,302		1,259
Asset impairment charges							(611)
Income (loss) from continuing operations	197,302		170,048		537,010		479,435
Public Storage Shareholders	197,302		170,048		537,010		479,435
Europe Self-Storage [Member]
Segment Reporting Information [Line Items]
Interest and other income	5,979		6,164		22,636		18,837
Total revenues	5,979		6,164		22,636		18,837
Income (loss) from continuing operations before equity in earnings of real estate entities, foreign currency exchange loss and gains on real estate sales and debt retirement, net and asset impairment charges	5,979		6,164		22,636		18,837
Equity in earnings of real estate entities	6,702		3,485		17,471		10,254
Foreign currency exchange loss	(28,253)		55,455		13,495		(28,592)
Income (loss) from continuing operations	(15,572)		65,104		53,602		499
Public Storage Shareholders	(15,572)		65,104		53,602		499
Commercial [Member]
Segment Reporting Information [Line Items]
Ancillary operations	3,590		3,496		11,010		10,709
Interest and other income	141				664
Total revenues	3,731		3,496		11,674		10,709
Ancillary operations	1,381		1,500		4,247		4,349
Depreciation and amortization	659		655		1,987		1,965
Total expenses	2,040		2,155		6,234		6,314
Income (loss) from continuing operations before equity in earnings of real estate entities, foreign currency exchange loss and gains on real estate sales and debt retirement, net and asset impairment charges	1,691		1,341		5,440		4,395
Equity in earnings of real estate entities	8,117		5,091		22,982		16,279
Income (loss) from continuing operations	9,808		6,432		28,422		20,674
Public Storage Shareholders	9,808		6,432		28,422		20,674
Other Items Not Allocated To Segments [Member]
Segment Reporting Information [Line Items]
Ancillary operations	26,421		23,092		74,807		68,114
Interest and other income	755		611		1,918		3,186
Total revenues	27,176		23,703		76,725		71,300
Ancillary operations	8,412		5,591		24,057		20,711
General and administrative	14,116		8,910		40,944		29,068
Interest expense	5,862		7,838		18,779		22,455
Total expenses	28,390		22,339		83,780		72,234
Income (loss) from continuing operations before equity in earnings of real estate entities, foreign currency exchange loss and gains on real estate sales and debt retirement, net and asset impairment charges	(1,214)		1,364		(7,055)		(934)
Gains on real estate sales and debt retirement, net	4,983				5,111		679
Asset impairment charges	(2,186)				(2,186)		(1,338)
Income (loss) from continuing operations	1,583		1,364		(4,130)		(1,593)
Discontinued operations	1,392		2,863		1,118		7,889
Public Storage Shareholders	$ 2,975		$ 4,227		$ (3,012)		$ 6,296

[1] The foreign currency exchange gains and losses reflected on our statements of income are comprised primarily of foreign currency exchange gains and losses on the Euro-denominated loan to Shurgard Europe.